-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support jdbc source for spark-loader #306
Conversation
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
============================================
- Coverage 67.83% 67.49% -0.34%
Complexity 877 877
============================================
Files 86 86
Lines 4004 4024 +20
Branches 474 475 +1
============================================
Hits 2716 2716
- Misses 1084 1104 +20
Partials 204 204
Continue to review full report at Codecov.
|
Object[] structFields = JavaConverters.asJavaCollection(row.schema().toList()) | ||
.toArray(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the differ with list.toArray()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
row.schema().toList()
will return scala list
, need to convert to java one.
closed #305