feat: support jdbc source for spark-loader #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
============================================
- Coverage 67.83% 67.49% -0.34%
Complexity 877 877
============================================
Files 86 86
Lines 4004 4024 +20
Branches 474 475 +1
============================================
Hits 2716 2716
- Misses 1084 1104 +20
Partials 204 204
Continue to review full report at Codecov.
|
javeme
approved these changes
Jul 15, 2022
imbajin
reviewed
Jul 15, 2022
Comment on lines
+213
to
+214
| Object[] structFields = JavaConverters.asJavaCollection(row.schema().toList()) | ||
| .toArray(); |
There was a problem hiding this comment.
the differ with list.toArray()?
There was a problem hiding this comment.
row.schema().toList() will return scala list, need to convert to java one.
imbajin
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #305