Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt java-client: support cpyher query api #272

Merged
merged 4 commits into from
May 17, 2022

Conversation

jadepeng
Copy link
Contributor

adapt java-client for hugegraph (see apache/incubator-hugegraph#1866)

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #272 (e5c282a) into master (7c39453) will increase coverage by 2.15%.
The diff coverage is 58.82%.

@@             Coverage Diff              @@
##             master     #272      +/-   ##
============================================
+ Coverage     75.74%   77.89%   +2.15%     
+ Complexity     1847      972     -875     
============================================
  Files           235      156      -79     
  Lines          7766     4080    -3686     
  Branches        685      242     -443     
============================================
- Hits           5882     3178    -2704     
+ Misses         1501      723     -778     
+ Partials        383      179     -204     
Impacted Files Coverage Δ
...ava/com/baidu/hugegraph/api/gremlin/CypherAPI.java 50.00% <50.00%> (ø)
...java/com/baidu/hugegraph/driver/CypherManager.java 57.14% <57.14%> (ø)
...in/java/com/baidu/hugegraph/driver/HugeClient.java 82.35% <66.66%> (-0.99%) ⬇️
...m/baidu/hugegraph/structure/constant/HugeType.java 90.62% <100.00%> (+0.30%) ⬆️
...ugegraph/loader/serializer/InputProgressDeser.java
...m/baidu/hugegraph/loader/task/BatchInsertTask.java
...baidu/hugegraph/loader/source/file/FileSource.java
...baidu/hugegraph/loader/reader/jdbc/RowFetcher.java
.../baidu/hugegraph/loader/progress/LoadProgress.java
.../baidu/hugegraph/loader/task/ParseTaskBuilder.java
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c39453...e5c282a. Read the comment docs.

@javeme
Copy link
Contributor

javeme commented May 12, 2022

The code looks fine, wait for the server apache/incubator-hugegraph#1866 PR merged~
@jadepeng Did you test it locally?

@jadepeng
Copy link
Contributor Author

The code looks fine, wait for the server apache/incubator-hugegraph#1866 PR merged~ @jadepeng Did you test it locally?

Tested

@javeme
Copy link
Contributor

javeme commented May 12, 2022

@javeme javeme changed the title adapt java-client for hugegraph pr 1866, support cpyher api adapt java-client: support cpyher query api May 16, 2022
@@ -0,0 +1,46 @@
/*
* Copyright 2017 HugeGraph Authors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to use 2022?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original codes are also 2017, we can update them uniformly in the future.

@@ -0,0 +1,44 @@
/*
* Copyright 2017 HugeGraph Authors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@@ -0,0 +1,60 @@
/*
* Copyright 2017 HugeGraph Authors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@imbajin imbajin merged commit 6e39907 into apache:master May 17, 2022
@javeme javeme added the client hugegraph-client label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client hugegraph-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants