Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: init toolchain pom for all modules #267

Merged
merged 1 commit into from
Apr 27, 2022
Merged

refact: init toolchain pom for all modules #267

merged 1 commit into from
Apr 27, 2022

Conversation

imbajin
Copy link
Member

@imbajin imbajin commented Apr 26, 2022

Done:

TODO: improve the pom should be careful, it may cause a string of problems:)

refer maven guid to unify all submodule with a ${revision} property to avoid useless version change
@imbajin
Copy link
Member Author

imbajin commented Apr 26, 2022

@z7658329 u could use this branch to test the license check plugin & review it

@z7658329
Copy link
Member

z7658329 commented Apr 26, 2022

it seems dose not work, there are some error, ex:
image

@imbajin
Copy link
Member Author

imbajin commented Apr 27, 2022

it seems dose not work, there are some error, ex: image

The CI problem fixed in a separate pr, this pr construct the struct

@corgiboygsj corgiboygsj merged commit 4caf46d into master Apr 27, 2022
@corgiboygsj corgiboygsj deleted the pom branch April 27, 2022 08:53
@corgiboygsj corgiboygsj restored the pom branch April 27, 2022 08:53
@corgiboygsj corgiboygsj deleted the pom branch April 27, 2022 08:53
@javeme javeme added the ci Continuous integration label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants