release loader v0.12 #238
Merged
release loader v0.12 #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
force-pushed
the
update_server_0.12
branch
3 times, most recently
from
58cbaec
to
718e03e
Compare
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
=========================================
Coverage 73.54% 73.54%
Complexity 876 876
=========================================
Files 81 81
Lines 3689 3689
Branches 439 439
=========================================
Hits 2713 2713
Misses 777 777
Partials 199 199
Continue to review full report at Codecov.
|
javeme
reviewed
Dec 28, 2021
.github/workflows/ci.yml
Outdated
| @@ -44,7 +44,7 @@ jobs: | |||
| - name: Compile | |||
| run: | | |||
| mvn install:install-file -Dfile=$STATIC_DIR/lib/ojdbc8-12.2.0.1.jar -DgroupId=com.oracle -DartifactId=ojdbc8 -Dversion=12.2.0.1 -Dpackaging=jar | |||
| mvn compile -Dmaven.javadoc.skip=true | grep -v "Downloading\|Downloaded" | |||
| mvn compile -Dmaven.javadoc.skip=true | |||
There was a problem hiding this comment.
can keep | grep -v "Downloading\|Downloaded" here, but need to "grep" at line 65
coderzc
force-pushed
the
update_server_0.12
branch
from
718e03e
to
66bfd5b
Compare
imbajin
reviewed
Dec 28, 2021
pom.xml
Outdated
Comment on lines
63
to
65
| <groupId>com.baidu.hugegraph</groupId> | ||
| <artifactId>hugegraph-common</artifactId> | ||
| <version>1.8.9</version> | ||
| <version>2.0.1</version> |
There was a problem hiding this comment.
@javeme why we need import common again (due to client imported it)
There was a problem hiding this comment.
not sure why to import again, we can remove it
coderzc
force-pushed
the
update_server_0.12
branch
2 times, most recently
from
ea757ea
to
43e3bc3
Compare
coderzc
force-pushed
the
update_server_0.12
branch
from
43e3bc3
to
84e5164
Compare
javeme
approved these changes
Dec 28, 2021
imbajin
approved these changes
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.