-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release loader v0.12 #238
release loader v0.12 #238
Conversation
58cbaec
to
718e03e
Compare
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
=========================================
Coverage 73.54% 73.54%
Complexity 876 876
=========================================
Files 81 81
Lines 3689 3689
Branches 439 439
=========================================
Hits 2713 2713
Misses 777 777
Partials 199 199
Continue to review full report at Codecov.
|
.github/workflows/ci.yml
Outdated
@@ -44,7 +44,7 @@ jobs: | |||
- name: Compile | |||
run: | | |||
mvn install:install-file -Dfile=$STATIC_DIR/lib/ojdbc8-12.2.0.1.jar -DgroupId=com.oracle -DartifactId=ojdbc8 -Dversion=12.2.0.1 -Dpackaging=jar | |||
mvn compile -Dmaven.javadoc.skip=true | grep -v "Downloading\|Downloaded" | |||
mvn compile -Dmaven.javadoc.skip=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can keep | grep -v "Downloading\|Downloaded"
here, but need to "grep" at line 65
718e03e
to
66bfd5b
Compare
pom.xml
Outdated
<groupId>com.baidu.hugegraph</groupId> | ||
<artifactId>hugegraph-common</artifactId> | ||
<version>1.8.9</version> | ||
<version>2.0.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javeme why we need import common again (due to client imported it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why to import again, we can remove it
ea757ea
to
43e3bc3
Compare
43e3bc3
to
84e5164
Compare
No description provided.