Check header not empty when user customized it #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linary
force-pushed
the
check-header-not-empty
branch
2 times, most recently
from
8f14857
to
c4a2bf4
Compare
Change-Id: Iab8011d2235d29a79ad65d4cc380d801d08896ac
Linary
force-pushed
the
check-header-not-empty
branch
from
c4a2bf4
to
b7d39ce
Compare
javeme
reviewed
Mar 7, 2021
assembly/travis/install-hadoop.sh
Outdated
| sudo tee /etc/apt/sources.list.d/hdp.list <<EOF | ||
| deb http://public-repo-1.hortonworks.com/HDP/ubuntu${UBUNTU_VERSION}/2.x/updates/2.6.5.0 HDP main | ||
| sudo tee /etc/apt/sources.list.d/cdh.list <<EOF | ||
| deb [arch=amd64] http://archive.cloudera.com/cdh5/ubuntu/${UBUNTU_CODENAME}/amd64/cdh ${UBUNTU_CODENAME}-cdh5 contrib |
There was a problem hiding this comment.
why we need to change the download source
There was a problem hiding this comment.
origin install hdfs failed
|
|
Linary
force-pushed
the
check-header-not-empty
branch
16 times, most recently
from
37952e4
to
fccc057
Compare
Change-Id: Idfdcba4b04480294cf648232a95930ab885a743b
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
============================================
- Coverage 72.98% 72.84% -0.14%
- Complexity 824 828 +4
============================================
Files 79 79
Lines 3480 3499 +19
Branches 416 425 +9
============================================
+ Hits 2540 2549 +9
- Misses 741 750 +9
- Partials 199 200 +1 Continue to review full report at Codecov.
|
Linary
force-pushed
the
check-header-not-empty
branch
from
fccc057
to
d1df678
Compare
javeme
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Iab8011d2235d29a79ad65d4cc380d801d08896ac