Add checkstyle plugin to check code style #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linary
force-pushed
the
check-style
branch
3 times, most recently
from
94bc3e5
to
b974573
Compare
javeme
reviewed
Dec 16, 2020
| @@ -82,8 +82,10 @@ public EdgeMapping mapping() { | |||
| int size = Math.max(sources.size(), targets.size()); | |||
| List<Edge> edges = new ArrayList<>(size); | |||
| for (int i = 0; i < size; i++) { | |||
| Vertex source = i < sources.size() ? sources.get(i) : sources.get(0); | |||
| Vertex target = i < targets.size() ? targets.get(i) : targets.get(0); | |||
| Vertex source = i < sources.size() ? sources.get(i) : | |||
There was a problem hiding this comment.
prefer to wrap line after "?"
| Vertex target = i < targets.size() ? targets.get(i) : targets.get(0); | ||
| Vertex source = i < sources.size() ? sources.get(i) : | ||
| sources.get(0); | ||
| Vertex target = i < targets.size() ? targets.get(i) : |
| this.timeZone = timeZone != null ? timeZone : Constants.TIME_ZONE; | ||
| this.skippedLine = skippedLine != null ? skippedLine : new SkippedLine(); | ||
| this.skippedLine = skippedLine != null ? skippedLine : | ||
| new SkippedLine(); |
Change-Id: Ieb294cbe7d9fafa4ed468b965abe61135cafd50d
javeme
approved these changes
Dec 16, 2020
houzhizhen
approved these changes
Dec 16, 2020
zhoney
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ieb294cbe7d9fafa4ed468b965abe61135cafd50d