Fix date unequal since client and server has not same time zone #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
=============================================
+ Coverage 38.43% 72.92% +34.49%
- Complexity 427 824 +397
=============================================
Files 79 79
Lines 3471 3472 +1
Branches 415 416 +1
=============================================
+ Hits 1334 2532 +1198
+ Misses 1974 741 -1233
- Partials 163 199 +36 Continue to review full report at Codecov.
|
Change-Id: I7e8a6a8f8a7da89df517655cdc90b9b3a1acc530
Linary
force-pushed
the
fix-date-unequal-with-notsame-tz
branch
from
14f681f
to
24488b0
Compare
javeme
reviewed
Dec 15, 2020
javeme
requested changes
Dec 15, 2020
| "Date value must be List<String> class"); | ||
| List<String> actualDateList = (List<String>) actualDates; | ||
| E.checkArgument(expectDates.size() == actualDateList.size(), | ||
| "The size of expect and actual dates must be equal"); |
There was a problem hiding this comment.
call Assert.assertEquals with error message param
Linary
force-pushed
the
fix-date-unequal-with-notsame-tz
branch
from
16a6779
to
1d5426f
Compare
Change-Id: I708c3678df8ce64d5db49c40f8a3642738f00ca9
Linary
force-pushed
the
fix-date-unequal-with-notsame-tz
branch
from
1d5426f
to
bf96acb
Compare
javeme
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.