Install hugegraph from github instead of download link #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javeme
reviewed
Dec 9, 2020
assembly/travis/install-hugegraph.sh
Outdated
| @@ -3,53 +3,46 @@ | |||
| set -ev | |||
|
|
|||
| if [[ $# -ne 1 ]]; then | |||
| echo "Must pass server version of hugegraph" | |||
| echo "Must pass base branch name of pull request" | |||
There was a problem hiding this comment.
add install-hugegraph-from-source.sh and keep install-hugegraph-from-tar.sh
Change-Id: I07e78cae40d7ab90640a1b7ca3bf57197c885cf1
Change-Id: Ide5ab2ef23ac0be55db54761dbb537383e3c2f6f
Linary
force-pushed
the
travis-fetch-server-from-github
branch
from
f784465
to
39836b8
Compare
javeme
previously approved these changes
Dec 11, 2020
Linary
force-pushed
the
travis-fetch-server-from-github
branch
from
9d60943
to
81fc5ce
Compare
javeme
previously approved these changes
Dec 11, 2020
|
ci error |
Linary
force-pushed
the
travis-fetch-server-from-github
branch
9 times, most recently
from
d95077d
to
98cecac
Compare
zhoney
reviewed
Dec 14, 2020
assembly/travis/set-env.sh
Outdated
| #1 | ||
| #1 | ||
| #XXG | ||
| #sudo cp /usr/share/zoneinfo/Asia/Shanghai /etc/localtime |
There was a problem hiding this comment.
delete if no use from line 5 to line 11
| Assert.assertEquals(expectTimeStamp, actualTimeStamp); | ||
| } | ||
|
|
||
|
|
Linary
force-pushed
the
travis-fetch-server-from-github
branch
3 times, most recently
from
5af0ce2
to
14f681f
Compare
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
=============================================
+ Coverage 38.40% 72.92% +34.52%
- Complexity 427 824 +397
=============================================
Files 79 79
Lines 3471 3472 +1
Branches 415 416 +1
=============================================
+ Hits 1333 2532 +1199
+ Misses 1974 741 -1233
- Partials 164 199 +35 Continue to review full report at Codecov.
|
Change-Id: I2c051aeb81a60cfa0cd4418ca1361d7fd1ed758a
Linary
force-pushed
the
travis-fetch-server-from-github
branch
from
14f681f
to
d0af262
Compare
javeme
approved these changes
Dec 14, 2020
javeme
reviewed
Dec 14, 2020
| protected static final String TRUST_STORE_PASSWORD = "changeit"; | ||
| protected static final String HTTPS_PROTOCOL = "https"; | ||
| protected static final String TRUST_STORE_FILE = | ||
| "assembly/travis/conf/hugegraph.truststore"; |
There was a problem hiding this comment.
seems TRUST_STORE_FILE is unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I07e78cae40d7ab90640a1b7ca3bf57197c885cf1