Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line retainAll doesn't modify names and values array #110

Merged
merged 3 commits into from
Nov 26, 2019

Conversation

Linary
Copy link
Contributor

@Linary Linary commented Nov 25, 2019

Change-Id: I383b3b20a162816098aa8ee8468e8255b3553fdc

Change-Id: I383b3b20a162816098aa8ee8468e8255b3553fdc
@Linary
Copy link
Contributor Author

Linary commented Nov 25, 2019

fix #108

@codecov
Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #110 into master will increase coverage by 0.22%.
The diff coverage is 95.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #110      +/-   ##
============================================
+ Coverage     74.71%   74.93%   +0.22%     
+ Complexity      611      609       -2     
============================================
  Files            63       63              
  Lines          2349     2346       -3     
  Branches        248      246       -2     
============================================
+ Hits           1755     1758       +3     
+ Misses          442      436       -6     
  Partials        152      152
Impacted Files Coverage Δ Complexity Δ
...baidu/hugegraph/loader/builder/ElementBuilder.java 91.08% <100%> (ø) 32 <0> (ø) ⬇️
...baidu/hugegraph/loader/reader/jdbc/RowFetcher.java 84.14% <100%> (+0.19%) 14 <0> (ø) ⬇️
...n/java/com/baidu/hugegraph/loader/reader/Line.java 94.11% <95.45%> (+28.32%) 11 <6> (+1) ⬆️
...baidu/hugegraph/loader/source/jdbc/JDBCVendor.java 32.87% <0%> (-3.43%) 9% <0%> (-3%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deb52fc...9e7bb71. Read the comment docs.

Change-Id: Ie0aa44b9a24c1b737469df7c3c7aa9000b4939ca
zhoney
zhoney previously approved these changes Nov 26, 2019
Change-Id: I38eb682d57cfcd29468f758ad005343a54c5ebb9
@zhoney zhoney merged commit 63aea9c into master Nov 26, 2019
@zhoney zhoney deleted the line-retain-bug branch November 26, 2019 07:46
imbajin pushed a commit that referenced this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants