-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support read hadoop conf file #105
Conversation
src/main/java/com/baidu/hugegraph/loader/reader/hdfs/HDFSFileReader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/baidu/hugegraph/loader/reader/hdfs/HDFSFileReader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/baidu/hugegraph/loader/reader/hdfs/HDFSFileReader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/baidu/hugegraph/loader/reader/hdfs/HDFSFileReader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/baidu/hugegraph/loader/reader/hdfs/HDFSFileReader.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
============================================
+ Coverage 74.93% 75.39% +0.45%
- Complexity 609 611 +2
============================================
Files 63 63
Lines 2346 2337 -9
Branches 246 245 -1
============================================
+ Hits 1758 1762 +4
+ Misses 436 425 -11
+ Partials 152 150 -2
Continue to review full report at Codecov.
|
6edc835
to
126286b
Compare
src/main/java/com/baidu/hugegraph/loader/reader/hdfs/HDFSFileReader.java
Outdated
Show resolved
Hide resolved
src/test/java/com/baidu/hugegraph/loader/test/functional/HDFSLoadTest.java
Show resolved
Hide resolved
src/test/java/com/baidu/hugegraph/loader/test/functional/HDFSLoadTest.java
Outdated
Show resolved
Hide resolved
126286b
to
549a0b7
Compare
src/test/java/com/baidu/hugegraph/loader/test/functional/HDFSLoadTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/baidu/hugegraph/loader/reader/hdfs/HDFSFileReader.java
Outdated
Show resolved
Hide resolved
src/test/java/com/baidu/hugegraph/loader/test/functional/HDFSLoadTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/baidu/hugegraph/loader/test/functional/HDFSLoadTest.java
Show resolved
Hide resolved
0f8bc32
to
27ebd92
Compare
src/main/java/com/baidu/hugegraph/loader/source/hdfs/HDFSSource.java
Outdated
Show resolved
Hide resolved
811dcff
to
759e202
Compare
src/test/java/com/baidu/hugegraph/loader/test/functional/FileLoadTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/baidu/hugegraph/loader/test/functional/FileLoadTest.java
Outdated
Show resolved
Hide resolved
@AfterClass | ||
public static void tearDown() { | ||
ioUtil.close(); | ||
public String structPath(String fileName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems same with static configPath(String)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let it call configPath(String), and it will be override by HDFSLoadTest
@@ -305,6 +279,8 @@ public void testVertexIdExceedLimit() { | |||
}; | |||
Assert.assertThrows(ParseException.class, () -> { | |||
HugeGraphLoader.main(args); | |||
}, e -> { | |||
System.out.println(e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add Assert.assertTrue(e.contains("xx")) if necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing special, delete it.
@@ -305,6 +279,8 @@ public void testVertexIdExceedLimit() { | |||
}; | |||
Assert.assertThrows(ParseException.class, () -> { | |||
HugeGraphLoader.main(args); | |||
}, e -> { | |||
System.out.println(e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add Assert.assertTrue(e.contains("xx")) if necessary
src/main/java/com/baidu/hugegraph/loader/reader/hdfs/HDFSFileReader.java
Outdated
Show resolved
Hide resolved
src/test/java/com/baidu/hugegraph/loader/test/functional/HDFSLoadTest.java
Outdated
Show resolved
Hide resolved
return conf; | ||
} | ||
|
||
private static void checkExist(FileSystem fs, Path path) { | ||
LoadException e = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems useless changes, why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeap
src/test/java/com/baidu/hugegraph/loader/test/functional/FileLoadTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/baidu/hugegraph/loader/test/functional/FileLoadTest.java
Outdated
Show resolved
Hide resolved
"value_list_property_in_csv_file_with_same_delimiter/struct.json"), | ||
"-s", configPath( | ||
"-s", structPath( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto. Please handle all same conditions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
total 4 locations
4566629
to
884ac76
Compare
implement #104