-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate release actions support mulit os #197
Changes from 1 commit
7e03336
51c5372
b83bfa3
ed1c1b6
388c311
d157a30
6a58e1a
8049322
be7b948
f3841f2
28bceba
3b48708
3bdddeb
08ff276
36678b6
ed900cf
0d5eb38
df3487c
63a0cf2
220852f
ab015c0
b0e525d
5d8b810
12908a1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -94,7 +94,7 @@ jobs: | |
echo "$i" | ||
# 4.0 check the directory name include "incubating" | ||
if [[ ! "$i" =~ "incubating" ]]; then | ||
echo "The package name should include incubating" && exit 1 | ||
echo "The package name $i should include incubating" && exit 1 | ||
fi | ||
tar xzvf "$i" || exit | ||
cd "$(basename "$i" .tar.gz)" || exit | ||
|
@@ -133,6 +133,7 @@ jobs: | |
COUNT=$(find . -type f | perl -lne 'print if -B' | grep -v *.txt | wc -l) | ||
if [[ $COUNT -ne 0 ]]; then | ||
find . -type f | perl -lne 'print if -B' | ||
# due to the search script is not perfect, we can't exit here (check manually) | ||
echo "The package shouldn't include binary file, but get $COUNT" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Find a critical problem here, we need exclude the files with a
This is the 1st priority we need to fix and enhance it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
1.should exit while check failed ? |
||
fi | ||
|
||
|
@@ -141,7 +142,8 @@ jobs: | |
cd .. && echo "skip computer module in java8" | ||
continue | ||
fi | ||
mvn package -DskipTests -ntp && ls -lh | ||
mvn package -DskipTests -ntp -e || exit 1 | ||
ls -lh | ||
cd .. || exit | ||
done | ||
|
||
|
@@ -180,6 +182,7 @@ jobs: | |
echo "test hubble" | ||
cd ./*hubble*${{ inputs.release_version }} || exit | ||
cat conf/hugegraph-hubble.properties && bin/start-hubble.sh | ||
# TODO: need stop the server here | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we can also add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
seems should stop server after toolchain test There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
cd ../../../ || exit | ||
rm -rf ./*src* && ls -lh | ||
|
||
|
@@ -190,12 +193,12 @@ jobs: | |
echo "$i" | ||
# 7.0 check the directory name include "incubating" | ||
if [[ ! "$i" =~ "incubating" ]]; then | ||
echo "The package name should include incubating" && exit 1 | ||
echo "The package name $i should include incubating" && exit 1 | ||
fi | ||
tar xzvf "$i" || exit | ||
|
||
# 7.1 check root dir include "NOTICE"/"LICENSE"/"DISCLAIMER" files & "licenses" dir | ||
cd "$(basename "$i" .tar.gz)" && ls -lh || exit | ||
# 7.1 check root dir include "NOTICE"/"LICENSE"/"DISCLAIMER" & "licenses" dir | ||
(cd "$(basename "$i" .tar.gz)" && ls -lh) || exit | ||
if [[ ! -f "LICENSE" ]]; then | ||
echo "The package should include LICENSE file" && exit 1 | ||
fi | ||
|
@@ -265,10 +268,11 @@ jobs: | |
cat conf/hugegraph-hubble.properties | ||
bin/stop-hubble.sh && bin/start-hubble.sh | ||
cd - || exit | ||
# TODO: need stop the server here | ||
|
||
strategy: | ||
fail-fast: false | ||
matrix: | ||
java_version: [ '8','11' ] | ||
# TODO: support windows-latest or other os in future | ||
# TODO: support windows-latest or other OS in future | ||
os: [ubuntu-latest, macos-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need a better way to search binary files(and exclude some files marked in properties)
no we can't exit here,but we should search the key word in action log manually