Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable some clippy rules #647

Closed
jiacai2050 opened this issue Feb 14, 2023 · 0 comments · Fixed by #658
Closed

Re-enable some clippy rules #647

jiacai2050 opened this issue Feb 14, 2023 · 0 comments · Fixed by #658
Labels
feature New feature or request

Comments

@jiacai2050
Copy link
Contributor

Describe This Problem

When doing #641, lots of clippy error arise, I disable some rules for quick dev. We should reenable those rules.

Proposal

Remove ad-hoc clippy fix

clippy:
	cd $(DIR); cargo clippy --all-targets --all-features --workspace -- -D warnings

Additional Context

No response
@jiacai2050 jiacai2050 added the feature New feature or request label Feb 14, 2023
@jiacai2050 jiacai2050 changed the title Reenable some clippy rules Re-enable some clippy rules Feb 14, 2023
@jiacai2050 jiacai2050 mentioned this issue Feb 14, 2023
Merged
@ShiKaiWi ShiKaiWi mentioned this issue Feb 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix some clippy errors & add clippy.toml ShiKaiWi/ceresdb
1 participant
@jiacai2050