Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for [CVE-2020-1958] Apache Druid LDAP injection vulnerability #9600

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

jon-wei
Copy link
Contributor

@jon-wei jon-wei commented Apr 1, 2020

This is the fix for CVE-2020-1958 (https://lists.apache.org/thread.html/r9d437371793b410f8a8e18f556d52d4bb68e18c537962f6a97f4945e%40%3Cdev.druid.apache.org%3E) which was included in the 0.17.1 release, this PR adds the fix to master.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths.
  • added integration tests.
  • been tested in a test Druid cluster.

@jon-wei jon-wei added this to the 0.18.0 milestone Apr 1, 2020
Copy link
Contributor

@jihoonson jihoonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 after CI. @jon-wei thank you for the fix!

@lgtm-com
Copy link

lgtm-com bot commented Apr 1, 2020

This pull request fixes 1 alert when merging 74875a3 into e855c7f - view on LGTM.com

fixed alerts:

  • 1 for LDAP query built from user-controlled sources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants