Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TaskMaster giant lock fair #3050

Merged
merged 1 commit into from
Jun 2, 2016
Merged

Conversation

drcrallen
Copy link
Contributor

I THINK this

fixes #3046

@drcrallen
Copy link
Contributor Author

Related: #2024

@nishantmonu51
Copy link
Member

👍

@gianm
Copy link
Contributor

gianm commented Jun 2, 2016

👍

Although, IMO a more robust fix would be to use a counter that increments each time the overlord gains leadership such that two leadership cycles do not interfere with each other.

@gianm gianm merged commit 474286b into apache:master Jun 2, 2016
@drcrallen drcrallen deleted the fairTaskMasterLock branch June 2, 2016 20:10
@gianm gianm modified the milestones: 0.9.2, 0.9.1 Sep 23, 2016
seoeun25 added a commit to seoeun25/incubator-druid that referenced this pull request Feb 25, 2022
* Add QueryEvent and send it to kafka to history query.
* Remove Event#isSafeToBuffer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.9.0] Too fast leadership changes in overlord causes multiple leaders and service failure
3 participants