Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integer overflow in SegmentMetadataQuery numRows. #2890

Merged
merged 1 commit into from
Apr 27, 2016
Merged

Fix integer overflow in SegmentMetadataQuery numRows. #2890

merged 1 commit into from
Apr 27, 2016

Conversation

gianm
Copy link
Contributor

@gianm gianm commented Apr 27, 2016

numRows can easily overflow an int when merging is enabled.

@gianm gianm added the Bug label Apr 27, 2016
@gianm gianm added this to the 0.9.1 milestone Apr 27, 2016
@fjy
Copy link
Contributor

fjy commented Apr 27, 2016

👍

@xvrl
Copy link
Member

xvrl commented Apr 27, 2016

@gianm once we hit Long.MAX_VALUE we'll have to switch to doubles though :)

@xvrl
Copy link
Member

xvrl commented Apr 27, 2016

👍 after travis

@xvrl xvrl merged commit 90ce03c into apache:master Apr 27, 2016
@gianm gianm deleted the smq-numRows branch September 23, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@gianm @fjy @xvrl