-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QTL] Implement LookupExtractorFactory of namespaced lookup #2716
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
14f4c88
support LookupReferencesManager registration of namespaced lookup and…
sirpkt 7d75062
update KafkaExtractionNamespaceTest to reflect argument signature cha…
sirpkt e4ae726
Add more synchronization functionality to NamespaceLookupExtractorFac…
drcrallen a525a5f
Remove old way of using extraction namespaces
drcrallen 153925a
Merge remote-tracking branch 'upstream/master' into qtl_namespace_lookup
sirpkt c5cc36a
Merge branch 'namespaceLookupMovetoLookups' of https://github.com/met…
sirpkt 3b45ae2
Merge branch 'metamx-namespaceLookupMovetoLookups' into qtl_namespace…
sirpkt 379af21
Merge remote-tracking branch 'upstream/master' into qtl_namespace_lookup
sirpkt 5b35e42
resolve compile error by supporting LookupIntrospectHandler
sirpkt 688e7c1
Merge remote-tracking branch 'druid/master' into mergeMasterLookups
drcrallen 10fc4f8
Merge pull request #2 from metamx/mergeMasterLookups
sirpkt f2b6864
Merge remote-tracking branch 'upstream/master' into qtl_namespace_lookup
sirpkt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74 changes: 74 additions & 0 deletions
74
...namespace/src/main/java/io/druid/query/extraction/namespace/KafkaExtractionNamespace.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
/* | ||
* Licensed to Metamarkets Group Inc. (Metamarkets) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. Metamarkets licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package io.druid.query.extraction.namespace; | ||
|
||
import com.fasterxml.jackson.annotation.JsonCreator; | ||
import com.fasterxml.jackson.annotation.JsonProperty; | ||
import com.fasterxml.jackson.annotation.JsonTypeName; | ||
import com.google.common.base.Preconditions; | ||
|
||
import javax.validation.constraints.NotNull; | ||
import java.util.Properties; | ||
|
||
/** | ||
* | ||
*/ | ||
@JsonTypeName("kafka") | ||
public class KafkaExtractionNamespace implements ExtractionNamespace | ||
{ | ||
@JsonProperty | ||
private final String kafkaTopic; | ||
|
||
@JsonProperty | ||
private final Properties kafkaProperties; | ||
|
||
@JsonCreator | ||
public KafkaExtractionNamespace( | ||
@NotNull @JsonProperty(value = "kafkaTopic", required = true) final String kafkaTopic, | ||
@NotNull @JsonProperty(value = "kafkaProperites", required = true) final Properties kafkaProperties | ||
) | ||
{ | ||
Preconditions.checkNotNull(kafkaTopic, "kafkaTopic required"); | ||
this.kafkaTopic = kafkaTopic; | ||
this.kafkaProperties = kafkaProperties; | ||
} | ||
|
||
public String getKafkaTopic() | ||
{ | ||
return kafkaTopic; | ||
} | ||
|
||
public Properties getKafkaProperties() | ||
{ | ||
return kafkaProperties; | ||
} | ||
|
||
@Override | ||
public long getPollMs() | ||
{ | ||
return 0L; | ||
} | ||
|
||
@Override | ||
public String toString() | ||
{ | ||
return String.format("KafkaExtractionNamespace = { kafkaTopic = '%s' }", kafkaTopic); | ||
} | ||
} |
50 changes: 0 additions & 50 deletions
50
...raction-namespace/src/main/java/io/druid/query/lookup/KafkaExtractionNamespaceModule.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be required? also required=true is just a hint, you still have to enforce not null checks in constructor to be ACTUALLY required.