-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not merge] Appenderator stuff #1907
Conversation
ca4e732
to
54d628d
Compare
@@ -67,6 +73,8 @@ public static MetadataStorageTablesConfig fromBase(String base) | |||
@JsonCreator | |||
public MetadataStorageTablesConfig( | |||
@JsonProperty("base") String base, | |||
@JsonProperty("dataSource") String dataSourceTable, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list is getting kind of silly... we may want to consider a better way of handling this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
((not intended to be a blocker here))
thanks, this clarifies some of the doubts I had while reviewing #1896 |
ff7c917
to
af54ed0
Compare
1e9f934
to
0e49b67
Compare
Appenderators are a way of getting more control over the ingestion process than a Plumber allows. The idea is that existing Plumbers could be implemented using Appenderators, but you could also implement things that Plumbers can't do. Also: - RealtimeTuningConfig: Default basePersistDirectory now different per instance. - Sink: Ability to consider itself "finished" vs "still writable".
This is for push-based externally-coordinated ingestion, tranquility-style.
superseded by #2220 |
stuff related to #1642 -- PR for discussion, not yet suitable for merging. based off of #1896, as this PR depends on that one.