[Do not merge] Appenderator stuff #1907
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianm
force-pushed
the
appenderator
branch
2 times, most recently
from
ca4e732
to
54d628d
Compare
| @@ -67,6 +73,8 @@ public static MetadataStorageTablesConfig fromBase(String base) | |||
| @JsonCreator | |||
| public MetadataStorageTablesConfig( | |||
| @JsonProperty("base") String base, | |||
| @JsonProperty("dataSource") String dataSourceTable, | |||
There was a problem hiding this comment.
This list is getting kind of silly... we may want to consider a better way of handling this.
There was a problem hiding this comment.
((not intended to be a blocker here))
|
thanks, this clarifies some of the doubts I had while reviewing #1896 |
gianm
force-pushed
the
appenderator
branch
3 times, most recently
from
ff7c917
to
af54ed0
Compare
gianm
force-pushed
the
appenderator
branch
3 times, most recently
from
1e9f934
to
0e49b67
Compare
Appenderators are a way of getting more control over the ingestion process than a Plumber allows. The idea is that existing Plumbers could be implemented using Appenderators, but you could also implement things that Plumbers can't do. Also: - RealtimeTuningConfig: Default basePersistDirectory now different per instance. - Sink: Ability to consider itself "finished" vs "still writable".
This is for push-based externally-coordinated ingestion, tranquility-style.
|
superseded by #2220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stuff related to #1642 -- PR for discussion, not yet suitable for merging. based off of #1896, as this PR depends on that one.