Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSQ ingestion: Improve error message on encountering non-long timestamp column #17411

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Akshat-Jain
Copy link
Contributor

Description

This PR improves the error message during MSQ ingestion if we encounter a non-long timestamp column.

Sample error message shown to user:
image


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions bot added Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Oct 25, 2024
@LakshSingla
Copy link
Contributor

@Akshat-Jain can you add a test case for this? I doubt there is already one since you'd have to change the error message.

@Akshat-Jain
Copy link
Contributor Author

@LakshSingla Have added tests for the method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants