Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DartSqlResource: Return HTTP 202 on cancellation even if no such query. #17278

Merged
merged 1 commit into from
Oct 8, 2024

Commits on Oct 8, 2024

  1. DartSqlResource: Return HTTP 202 on cancellation even if no such query.

    Return HTTP 202 (Accepted) on cancellation, even if the requested query
    ID was not found.
    
    The main reason for this is that when the Router broadcasts DELETE requests
    to all Brokers, it returns the response from one of them randomly. If we
    return 404 when a query ID isn't found, then the Router randomly returns 404s
    even when the query really was found and canceled.
    
    This is also arguably still correct behavior. The cancellation request
    *was* accepted, it just won't do anything because the query was not in
    fact running.
    gianm committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    463084f View commit details
    Browse the repository at this point in the history