-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web console query view improvements #16991
Web console query view improvements #16991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some review comments
web-console/src/views/workbench-view/max-tasks-button/max-tasks-button.tsx
Outdated
Show resolved
Hide resolved
web-console/src/views/workbench-view/max-tasks-button/max-tasks-button.tsx
Outdated
Show resolved
Hide resolved
web-console/src/views/workbench-view/max-tasks-button/max-tasks-button.tsx
Outdated
Show resolved
Hide resolved
value={forceSegmentSortByTime} | ||
onValueChange={forceSegmentSortByTime => | ||
icon={IconNames.ROCKET_SLANT} | ||
text="Approximate COUNT(DISTINCT)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right now this option only shows up for MSQ, if you look at the deleted code it used to show up for all SQL (effectiveEngine !== 'native'
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait nevermind!
* Made maxNumTaskOptions configurable in the Query view * Updated the copy for taskAssignment options * Reordered options in engine menu for msq engine * fixed snapshot * maxNumTaskOptions -> maxTasksOptions * added back select destination item * fixed duplicate menu item * snapshot * Added the ability to hide certain engine menu options * Added the ability to hide/show more menu items * -> fn * -> fn
#17200) * Web console query view improvements (#16991) * Made maxNumTaskOptions configurable in the Query view * Updated the copy for taskAssignment options * Reordered options in engine menu for msq engine * fixed snapshot * maxNumTaskOptions -> maxTasksOptions * added back select destination item * fixed duplicate menu item * snapshot * Added the ability to hide certain engine menu options * Added the ability to hide/show more menu items * Make the tooltip better and improve structure (#17132) * switch to using arrays by default (#17133) * Web console: add stage graph (#17135) * Web console: revamp the experimental explore view (#17180) * explore revamp * remove ToDo * fix CodeQL * add tooltips * show issue on echart chars * fix: browser back does not refresh chart * fix maxRows 0 * be more resiliant to missing __time --------- Co-authored-by: Sébastien <sebastien@imply.io>
This improves three things: