Web console query view improvements #16991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogievetsky
requested changes
Sep 4, 2024
web-console/src/views/workbench-view/max-tasks-button/max-tasks-button.tsx
Outdated
Show resolved
Hide resolved
web-console/src/views/workbench-view/max-tasks-button/max-tasks-button.tsx
Outdated
Show resolved
Hide resolved
web-console/src/views/workbench-view/max-tasks-button/max-tasks-button.tsx
Outdated
Show resolved
Hide resolved
vogievetsky
reviewed
Sep 4, 2024
vogievetsky
reviewed
Sep 10, 2024
| value={forceSegmentSortByTime} | ||
| onValueChange={forceSegmentSortByTime => | ||
| icon={IconNames.ROCKET_SLANT} | ||
| text="Approximate COUNT(DISTINCT)" |
There was a problem hiding this comment.
right now this option only shows up for MSQ, if you look at the deleted code it used to show up for all SQL (effectiveEngine !== 'native')
vogievetsky
approved these changes
Sep 10, 2024
vogievetsky
pushed a commit
to vogievetsky/druid
that referenced
this pull request
Sep 30, 2024
* Made maxNumTaskOptions configurable in the Query view * Updated the copy for taskAssignment options * Reordered options in engine menu for msq engine * fixed snapshot * maxNumTaskOptions -> maxTasksOptions * added back select destination item * fixed duplicate menu item * snapshot * Added the ability to hide certain engine menu options * Added the ability to hide/show more menu items * -> fn * -> fn
kfaraz
pushed a commit
that referenced
this pull request
Oct 1, 2024
#17200) * Web console query view improvements (#16991) * Made maxNumTaskOptions configurable in the Query view * Updated the copy for taskAssignment options * Reordered options in engine menu for msq engine * fixed snapshot * maxNumTaskOptions -> maxTasksOptions * added back select destination item * fixed duplicate menu item * snapshot * Added the ability to hide certain engine menu options * Added the ability to hide/show more menu items * Make the tooltip better and improve structure (#17132) * switch to using arrays by default (#17133) * Web console: add stage graph (#17135) * Web console: revamp the experimental explore view (#17180) * explore revamp * remove ToDo * fix CodeQL * add tooltips * show issue on echart chars * fix: browser back does not refresh chart * fix maxRows 0 * be more resiliant to missing __time --------- Co-authored-by: Sébastien <sebastien@imply.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves three things: