Remove alert for pre-existing new columns while merging realtime schema #16989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfaraz
reviewed
Sep 3, 2024
Comment on lines
835
to
836
| "Realtime schema merge: datasource [%s] is missing columns to be updated. " | ||
| + "ExistingSignature [%s], deltaSchema [%s], missingUpdateColumns [%s].", |
There was a problem hiding this comment.
The alert description should be small. Don't include big objects like the existingSignatureor deltaSchema in it. You may add these fields separately using .addData().
kfaraz
reviewed
Sep 4, 2024
| existingNewColumns | ||
| ).emit(); | ||
| if (!missingUpdateColumns.isEmpty()) { | ||
| log.makeAlert("Datasource schema is missing columns to be updated in delta realtime segment schema.") |
There was a problem hiding this comment.
The message is confusing. Could you try to rephrase this to say exactly what went wrong and what can be done to remediate?
kfaraz
reviewed
Sep 4, 2024
| boolean missingUpdateColumns = false; | ||
| // new column to be added is already present in the existing schema | ||
| boolean existingNewColumns = false; | ||
| Set<String> missingUpdateColumns = new HashSet<>(); |
There was a problem hiding this comment.
Nit:
Suggested change
| Set<String> missingUpdateColumns = new HashSet<>(); | |
| final Set<String> missingUpdateColumns = new HashSet<>(); |
cryptoe
approved these changes
Sep 4, 2024
kfaraz
approved these changes
Sep 4, 2024
edgar2020
pushed a commit
to edgar2020/druid
that referenced
this pull request
Sep 5, 2024
…ma (apache#16989) Currently, an alert is thrown while merging datasource schema with realtime segment schema when the datasource schema already has update columns from the delta schema. This isn't an error condition since the datasource schema can have those columns from a different segment. One scenario in which this can occur is when multiple replicas for a task is run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue: #14989
Currently, an alert is thrown while merging datasource schema with realtime segment schema when the datasource schema already has update columns from the delta schema.
This isn't an error condition since the datasource schema can have those columns from a different segment.
One scenario in which this can occur is when multiple replicas for a task is run.
This PR has: