Filter out tombstone segments from metadata cache #16890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoe
reviewed
Aug 19, 2024
| @@ -2214,6 +2215,77 @@ protected void coldDatasourceSchemaExec() | |||
| Assert.assertEquals(0, latch.getCount()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testTombstoneSegmentIsNotAdded() throws InterruptedException | |||
There was a problem hiding this comment.
Nit: This test case is very similar to BSMC#testTombstoneSegmentIsNotAdded(). Can we do a bit of refactor to remove redundancy.
There was a problem hiding this comment.
The test is trying ensure that tombstone segments are not added to the Broker and Coordinator cache instances.
Refactoring the test wouldn't be very beneficial since,
- Timeline used in the two caches is different.
org.apache.druid.segment.metadata.AbstractSegmentMetadataCache#getSegmentMetadataSnapshotimplementation differs between the two instances.
cryptoe
approved these changes
Aug 19, 2024
hevansDev
pushed a commit
to hevansDev/druid
that referenced
this pull request
Aug 29, 2024
* Fix build * Support segment metadata queries for tombstones * Filter out tombstone segments from metadata cache * Revert some changes * checkstyle * Update docs
cryptoe
pushed a commit
that referenced
this pull request
Sep 13, 2024
This PR #16890 introduced a change to skip adding tombstone segments to the cache. It turns out that as a side effect tombstone segments appear unavailable in the console. This happens because availability of a segment in Broker is determined from the metadata cache. The fix is to keep the segment in the metadata cache but skip them from refresh. This doesn't affect any functionality as metadata query for tombstone returns empty causing continuous refresh of those segments.
findingrish
added a commit
to findingrish/druid
that referenced
this pull request
Sep 16, 2024
This PR apache#16890 introduced a change to skip adding tombstone segments to the cache. It turns out that as a side effect tombstone segments appear unavailable in the console. This happens because availability of a segment in Broker is determined from the metadata cache. The fix is to keep the segment in the metadata cache but skip them from refresh. This doesn't affect any functionality as metadata query for tombstone returns empty causing continuous refresh of those segments.
findingrish
added a commit
to findingrish/druid
that referenced
this pull request
Sep 16, 2024
This PR apache#16890 introduced a change to skip adding tombstone segments to the cache. It turns out that as a side effect tombstone segments appear unavailable in the console. This happens because availability of a segment in Broker is determined from the metadata cache. The fix is to keep the segment in the metadata cache but skip them from refresh. This doesn't affect any functionality as metadata query for tombstone returns empty causing continuous refresh of those segments.
pranavbhole
pushed a commit
to pranavbhole/druid
that referenced
this pull request
Sep 17, 2024
This PR apache#16890 introduced a change to skip adding tombstone segments to the cache. It turns out that as a side effect tombstone segments appear unavailable in the console. This happens because availability of a segment in Broker is determined from the metadata cache. The fix is to keep the segment in the metadata cache but skip them from refresh. This doesn't affect any functionality as metadata query for tombstone returns empty causing continuous refresh of those segments.
findingrish
added a commit
to findingrish/druid
that referenced
this pull request
Sep 19, 2024
This PR apache#16890 introduced a change to skip adding tombstone segments to the cache. It turns out that as a side effect tombstone segments appear unavailable in the console. This happens because availability of a segment in Broker is determined from the metadata cache. The fix is to keep the segment in the metadata cache but skip them from refresh. This doesn't affect any functionality as metadata query for tombstone returns empty causing continuous refresh of those segments.
abhishekagarwal87
pushed a commit
that referenced
this pull request
Sep 19, 2024
This PR #16890 introduced a change to skip adding tombstone segments to the cache. It turns out that as a side effect tombstone segments appear unavailable in the console. This happens because availability of a segment in Broker is determined from the metadata cache. The fix is to keep the segment in the metadata cache but skip them from refresh. This doesn't affect any functionality as metadata query for tombstone returns empty causing continuous refresh of those segments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broker attempts to continuously refresh tombstone segments due to missing metadata (due to a limitation with segment metadata queries, see: #12137).
This PR resolves the issue by preventing tombstone segments from being added to the metadata cache.
Related to #14989
This PR has: