Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename test builder MSQTester.setExpectedSegment #16837

Merged

Conversation

abhishekrb19
Copy link
Contributor

Changes:

  • Rename MSQTester.setExpectedSegment to MSQTester.setExpectedSegments
  • Add the expected segments for a couple of unit tests in testInsertWithMaxNumSegments and testReplaceWithMaxNumSegments. Previously there was a test limitation with the verifier that did not allow multiple partitions for a key , but that was recently fixed in Fixes a bug when running queries with a limit clause #16643

This PR has:

  • been self-reviewed.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.

@github-actions github-actions bot added Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Aug 2, 2024
@abhishekrb19 abhishekrb19 merged commit fe6772a into apache:master Aug 2, 2024
54 of 58 checks passed
@abhishekrb19 abhishekrb19 deleted the rename_msq_test_expected_segment branch August 2, 2024 17:01
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants