-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add indexer task success and failure metrics #16829
Add indexer task success and failure metrics #16829
Conversation
indexing-service/src/main/java/org/apache/druid/indexing/common/task/NoopFailingTask.java
Outdated
Show resolved
Hide resolved
indexing-service/src/main/java/org/apache/druid/indexing/worker/WorkerTaskManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might have already been discussed, but if the purpose is only to track failed and succeeded tasks, we already have task/running/count
, task/success/count
, task/failed/count
metrics emitted by the Overlord. Are those not sufficient?
https://druid.apache.org/docs/latest/operations/metrics#indexing-service
indexing-service/src/test/java/org/apache/druid/indexing/common/task/NoopFailingTask.java
Outdated
Show resolved
Hide resolved
We wanted to have this metric for each indexer node. The current metric doesn't provide per-host information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, otherwise looks good to me.
indexing-service/src/main/java/org/apache/druid/indexing/common/task/NoopTask.java
Outdated
Show resolved
Hide resolved
indexing-service/src/test/java/org/apache/druid/indexing/worker/WorkerTaskManagerTest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/server/metrics/WorkerTaskCountStatsMonitor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@kfaraz looks like the checks passed |
Sure, @rbankar7 ! |
Just merged. Thank you for the contribution @rbankar7 |
Adds indexer level task success and failure metrics
Description
This PR adds indexer-level task metrics-
the current
"worker/task/completed/count"
metric shows all the tasks completed irrespective of success or failure status so these metrics would help us get more visibility into the status of the completed tasksRelease note
Adds
indexer/task/failed/count
andindexer/task/failed/count
metricsThis PR has: