Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] batch 5 updating functions #16812

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Conversation

edgar2020
Copy link
Contributor

Description

Add examples to the sql-functions.md page

Updates the DIV, HUMAN_READABLE_BINARY_BYTE_FORMAT, HUMAN_READABLE_DECIMAL_BYTE_FORMAT, HUMAN_READABLE_DECIMAL_FORMAT, and SAFE_DIVIDE numeric functions.

This PR has:

  • been self-reviewed.

Copy link
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress. Request that we not include docs for the div function until it is available.

docs/querying/sql-functions.md Show resolved Hide resolved
docs/querying/sql-functions.md Outdated Show resolved Hide resolved
Copy link
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@techdocsmith techdocsmith merged commit 3bb6d40 into apache:master Jul 31, 2024
8 checks passed
sreemanamala pushed a commit to sreemanamala/druid that referenced this pull request Aug 6, 2024
* batch 5

* Update docs/querying/sql-functions.md

* applying suggestions

---------

Co-authored-by: Benedict Jin <asdf2014@apache.org>
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
vtlim pushed a commit to vtlim/druid that referenced this pull request Oct 8, 2024
* batch 5

* Update docs/querying/sql-functions.md

* applying suggestions

---------

Co-authored-by: Benedict Jin <asdf2014@apache.org>
(cherry picked from commit 3bb6d40)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants