Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Druid Console cannot open submit supervisor dialog #16736

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

AlbericByte
Copy link
Contributor

@AlbericByte AlbericByte commented Jul 16, 2024

Fixes #16589.

Description

Fix the web console issue, cannot open submit supervisor dialog
When user click on Load Data -> Streaming -> Other -> Submit Supervisor, the dialog doesn't open and user is directed to the home page.
On the other hand, Submit Task seems to work fine.
After modification, i have verified as following screenshot.
image

Fixed the bug ...

Release note

Fix Druid Console cannot open submit supervisor dialog


Key changed/added classes in this PR
  • console-application.tsx

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@AlbericByte
Copy link
Contributor Author

@abhishekagarwal87 if you have free time, could you help to review this.

@FrankChen021
Copy link
Member

introduced by #14395 ?

@AlbericByte
Copy link
Contributor Author

@vogievetsky could you help to have a look?

@AlbericByte
Copy link
Contributor Author

@vogievetsky welcome for any comment, i will update as soon as possible.

@AlbericByte
Copy link
Contributor Author

hi @vogievetsky and @FrankChen021 is there anyone available to review the code changes, i think this take minor effect, and i have verified on my local environment.

@FrankChen021
Copy link
Member

hi @vogievetsky and @FrankChen021 is there anyone available to review the code changes, i think this take minor effect, and i have verified on my local environment.

I'm not familiar with this part, even though you have verfied that the patch works fine and I believe your change is correct, it's better that @vogievetsky can take a look to see if there's anything left behind.

Copy link
Contributor

@vogievetsky vogievetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just seeing this. Thank you!

@vogievetsky vogievetsky merged commit 461727d into apache:master Aug 5, 2024
12 checks passed
@AlbericByte AlbericByte deleted the web-console branch August 7, 2024 17:28
@AlbericByte
Copy link
Contributor Author

Sorry just seeing this. Thank you!

Thanks, i am glad i can contribute the front end code.

@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Druid Console cannot open submit supervisor dialog
4 participants