Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Cleanup test impls of ServiceEmitter #15683

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Refactor: Cleanup test impls of ServiceEmitter #15683

merged 1 commit into from
Jan 15, 2024

Conversation

kfaraz
Copy link
Contributor

@kfaraz kfaraz commented Jan 15, 2024

Changes

  • Use StubServiceEmitter wherever applicable in tests
  • Remove other redundant test implementations

AmatyaAvadhanula
AmatyaAvadhanula approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@AmatyaAvadhanula AmatyaAvadhanula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kfaraz kfaraz merged commit 18d2a89 into apache:master Jan 15, 2024
83 checks passed
@kfaraz kfaraz deleted the cleanup_test_emitter branch January 15, 2024 12:07
@LakshSingla LakshSingla added this to the 29.0.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmatyaAvadhanula AmatyaAvadhanula AmatyaAvadhanula approved these changes

Assignees
No one assigned
Labels
Area - Ingestion Area - Streaming Ingestion
Projects
None yet
Milestone
29.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kfaraz @AmatyaAvadhanula @LakshSingla