-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update load query detail archive dialog for file input support #15632
Merged
vogievetsky
merged 8 commits into
apache:master
from
vogievetsky:load_big_detail_archive
Jan 11, 2024
Merged
Update load query detail archive dialog for file input support #15632
vogievetsky
merged 8 commits into
apache:master
from
vogievetsky:load_big_detail_archive
Jan 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the execution-submit-dialog to support file inputs instead of text inputs for better usability. Users can now submit their queries by selecting a JSON file directly or dragging the file into the dialog. Made appropriate UI adjustments to accommodate this change in execution-submit-dialog styles file.
gianm
approved these changes
Jan 6, 2024
techdocsmith
reviewed
Jan 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some style suggestions.
web-console/src/views/workbench-view/execution-submit-dialog/execution-submit-dialog.tsx
Outdated
Show resolved
Hide resolved
web-console/src/views/workbench-view/execution-submit-dialog/execution-submit-dialog.tsx
Outdated
Show resolved
Hide resolved
web-console/src/views/workbench-view/execution-submit-dialog/execution-submit-dialog.tsx
Outdated
Show resolved
Hide resolved
…xecution-submit-dialog.tsx Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…xecution-submit-dialog.tsx Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…xecution-submit-dialog.tsx Co-authored-by: Charles Smith <techdocsmith@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the execution-submit-dialog to support file inputs instead of text inputs for better usability. Users can now submit their queries by selecting a JSON file directly or dragging the file into the dialog. Made appropriate UI adjustments to accommodate this change in execution-submit-dialog styles file.