Handle half-eternity intervals while fetching segments with created dates #15608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfaraz
requested changes
Jan 8, 2024
| break; | ||
| } | ||
| } | ||
| final boolean compareAsString = intervals.stream().allMatch(Intervals::canCompareEndpointsAsStrings); |
There was a problem hiding this comment.
Please rename to compareIntervalsAsString or compareIntervalEndpointsAsString.
| r.getString("created_date") | ||
| ) | ||
| ) | ||
| .list() |
There was a problem hiding this comment.
I think I would prefer to build this list and then filter it later in a separate statement only if intervals is non-empty and we couldn't compare as strings.
So something like:
List<Pair<>> list = query.map().list();
if (intervals.isEmpty() || compareAsString) {
return list;
} else {
return list.stream().filter().collect();
}
kfaraz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a bug in retrieveUsedSegmentsAndCreatedDates where segments would not be returned for input intervals that partially overlap with eternity.
When the year does not lie in [1000, 9999], we fetch segments without a condition on the interval, and filter the results later (Similar to the method in SqlSegmentsMetadataQuery to fetch only payloads for segments)
This PR has: