Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase ServerConnector accept queue size #15596

Merged
merged 10 commits into from
Jan 5, 2024
Merged

Increase ServerConnector accept queue size #15596

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
128dcdb
Allow overwriting ServerConnector accept queue size
georgew5656 Dec 21, 2023
7b106e0
Use a single config
georgew5656 Dec 21, 2023
6ef08f7
Fix spacing
georgew5656 Dec 21, 2023
4f241ee
fix spacing
georgew5656 Dec 21, 2023
cbc3796
Merge branch 'master' of github.com:georgew5656/druid into maxQueueSize
georgew5656 Jan 2, 2024
7b90f6f
fixed value
georgew5656 Jan 4, 2024
2a3612a
read value from environment
georgew5656 Jan 4, 2024
32da136
fix spacing
georgew5656 Jan 4, 2024
185978d
Unpack value before reading
georgew5656 Jan 5, 2024
4e7ade5
check somaxconn on linux only
georgew5656 Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import com.google.inject.multibindings.Multibinder;
import com.sun.jersey.guice.JerseyServletModule;
import com.sun.jersey.guice.spi.container.servlet.GuiceContainer;
import org.apache.commons.lang3.SystemUtils;
import org.apache.druid.guice.Jerseys;
import org.apache.druid.guice.JsonConfigProvider;
import org.apache.druid.guice.LazySingleton;
Expand Down Expand Up @@ -83,7 +84,10 @@
import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import java.io.BufferedReader;
import java.io.IOException;
import java.nio.file.Files;
import java.nio.file.Paths;
import java.security.KeyStore;
import java.security.cert.CRL;
import java.util.ArrayList;
Expand Down Expand Up @@ -339,6 +343,7 @@ static Server makeAndInitializeServer(
// workaround suggested in -
// https://bugs.eclipse.org/bugs/show_bug.cgi?id=435322#c66 for jetty half open connection issues during failovers
connector.setAcceptorPriorityDelta(-1);
connector.setAcceptQueueSize(getTCPAcceptQueueSize());

List<ConnectionFactory> monitoredConnFactories = new ArrayList<>();
for (ConnectionFactory cf : connector.getConnectionFactories()) {
Expand Down Expand Up @@ -491,6 +496,23 @@ private static int getMaxJettyAcceptorsSelectorsNum(DruidNode druidNode)
return numServerConnector * 8;
}

private static int getTCPAcceptQueueSize()
{
if (SystemUtils.IS_OS_LINUX) {
try {
BufferedReader in = Files.newBufferedReader(Paths.get("/proc/sys/net/core/somaxconn"));
String acceptQueueSize = in.readLine();
if (acceptQueueSize != null) {
return Integer.parseInt(acceptQueueSize);
}
}
catch (Exception e) {
log.warn("Unable to read /proc/sys/net/core/somaxconn, falling back to default value for TCP accept queue size");
}
}
return 128; // Default value of net.core.somaxconn
}

@Provides
@LazySingleton
public JettyMonitor getJettyMonitor(DataSourceTaskIdHolder dataSourceTaskIdHolder)
Expand Down