Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow array_to_mv to support expression inputs #15528

Merged

Conversation

clintropolis
Copy link
Member

Description

Lifts validation restrictions on ARRAY_TO_MV function, used to coerce array types into native multi-value string dimensions to accept any type of expression. This should open up the flexibility of creating multi-value dimensions with MSQ to make it easier to still create multi-value dimensions with "arrayIngestMode":"array".


This PR has:

  • been self-reviewed.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • been tested in a test Druid cluster.

@clintropolis clintropolis changed the title lift restriction of array_to_mv to only support direct column access allow array_to_mv to support expression inputs Dec 8, 2023
Copy link
Contributor

@soumyava soumyava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vogievetsky vogievetsky merged commit e7c8f2e into apache:master Dec 9, 2023
83 checks passed
@clintropolis clintropolis deleted the array-to-mv-expression-input branch December 9, 2023 00:28
@LakshSingla LakshSingla added this to the 29.0.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants