add gson to dependencyManagement #15488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvrl
reviewed
Dec 5, 2023
pom.xml
Outdated
| <dependency> | ||
| <groupId>com.google.code.gson</groupId> | ||
| <artifactId>gson</artifactId> | ||
| <scope>compile</scope> |
There was a problem hiding this comment.
compile is the default scope, no need to specify it explicitly
xvrl
reviewed
Dec 5, 2023
xvrl
reviewed
Dec 5, 2023
Co-authored-by: Xavier Léauté <xl+github@xvrl.net>
xvrl
reviewed
Dec 5, 2023
Co-authored-by: Xavier Léauté <xl+github@xvrl.net>
Pankaj260100
pushed a commit
to confluentinc/druid
that referenced
this pull request
Dec 13, 2023
This change completes the change introduced in apache#15461 and unifies the version of gson dependency used between all the modules. gson is used by kubernetes-extension, avro-extensions, ranger-security, and as a test dependency in several core modules. --------- Co-authored-by: Xavier Léauté <xl+github@xvrl.net>
Pankaj260100
pushed a commit
to confluentinc/druid
that referenced
this pull request
Dec 19, 2023
This change completes the change introduced in apache#15461 and unifies the version of gson dependency used between all the modules. gson is used by kubernetes-extension, avro-extensions, ranger-security, and as a test dependency in several core modules. --------- Co-authored-by: Xavier Léauté <xl+github@xvrl.net>
Pankaj260100
pushed a commit
to confluentinc/druid
that referenced
this pull request
Dec 19, 2023
This change completes the change introduced in apache#15461 and unifies the version of gson dependency used between all the modules. gson is used by kubernetes-extension, avro-extensions, ranger-security, and as a test dependency in several core modules. --------- Co-authored-by: Xavier Léauté <xl+github@xvrl.net>
LakshSingla
added a commit
to LakshSingla/druid
that referenced
this pull request
Feb 12, 2024
This reverts commit ff0e838.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change completes the change introduced in #15461
and unifies the version of gson dependency used between all the modules.
gson is used by kubernetes-extension, avro-extensions, ranger-security, and as a test dependency in several core modules.
Change was green in local build and test, now for integration tests.
This PR has: