update guava to 32.0.1-jre to address CVEs #15482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvrl
reviewed
Dec 4, 2023
Comment on lines
286
to
287
| // This test is guava version sensitive when upgrading to guava > 32 | ||
| // the order changes to |
There was a problem hiding this comment.
it sounds like it would be less brittle to change this test to compare sets instead of lists. I don't think anything relies on ordering here.
There was a problem hiding this comment.
This came up in:
#14767
There is an effort on de-flaking tests, I would guess this will show up on their radar sooner or later.
There was a problem hiding this comment.
given that we changed the expected order once already I suggest we move to a set. I made suggestions you should be able to merge (mostly) as is.
There was a problem hiding this comment.
Thank you!
xvrl
reviewed
Dec 4, 2023
xvrl
reviewed
Dec 4, 2023
server/src/test/java/org/apache/druid/metadata/SqlSegmentsMetadataManagerTest.java
Outdated
Show resolved
Hide resolved
xvrl
reviewed
Dec 4, 2023
server/src/test/java/org/apache/druid/metadata/SqlSegmentsMetadataManagerTest.java
Show resolved
Hide resolved
…dataManagerTest.java Co-authored-by: Xavier Léauté <xl+github@xvrl.net>
…dataManagerTest.java Co-authored-by: Xavier Léauté <xl+github@xvrl.net>
xvrl
reviewed
Dec 4, 2023
server/src/test/java/org/apache/druid/metadata/SqlSegmentsMetadataManagerTest.java
Outdated
Show resolved
Hide resolved
…dataManagerTest.java Co-authored-by: Xavier Léauté <xl+github@xvrl.net>
xvrl
approved these changes
Dec 4, 2023
Pankaj260100
pushed a commit
to confluentinc/druid
that referenced
this pull request
Dec 13, 2023
Update guava to 32.0.1-jre to address two CVEs: CVE-2020-8908, CVE-2023-2976 This change requires a minor test change to remove assumptions about ordering. --------- Co-authored-by: Xavier Léauté <xl+github@xvrl.net>
Pankaj260100
added a commit
to confluentinc/druid
that referenced
this pull request
Dec 18, 2023
Pankaj260100
added a commit
to confluentinc/druid
that referenced
this pull request
Dec 18, 2023
Pankaj260100
pushed a commit
to confluentinc/druid
that referenced
this pull request
Dec 19, 2023
Update guava to 32.0.1-jre to address two CVEs: CVE-2020-8908, CVE-2023-2976 This change requires a minor test change to remove assumptions about ordering. --------- Co-authored-by: Xavier Léauté <xl+github@xvrl.net>
Pankaj260100
added a commit
to confluentinc/druid
that referenced
this pull request
Dec 19, 2023
Pankaj260100
pushed a commit
to confluentinc/druid
that referenced
this pull request
Dec 19, 2023
Update guava to 32.0.1-jre to address two CVEs: CVE-2020-8908, CVE-2023-2976 This change requires a minor test change to remove assumptions about ordering. --------- Co-authored-by: Xavier Léauté <xl+github@xvrl.net>
Pankaj260100
added a commit
to confluentinc/druid
that referenced
this pull request
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update guava to 32.0.1-jre to address two CVEs:
CVE-2020-8908, CVE-2023-2976
This change requires a minor test change to remove assumptions about ordering.
This PR has: