Web console: better management proxy detection #15453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintropolis
approved these changes
Nov 29, 2023
![github-advanced-security[bot]](https://github.com/avatars/in/57789?s=60&v=4){kind=small}
server/src/test/java/org/apache/druid/server/AsyncManagementForwardingServletTest.java
Fixed
Show fixed
Hide fixed
yashdeep97
pushed a commit
to yashdeep97/druid
that referenced
this pull request
Dec 1, 2023
* better management proxy detection * fix checkstyle issue * add test * test should read the body also * use ObjectMapper * assert read ammount
yashdeep97
pushed a commit
to yashdeep97/druid
that referenced
this pull request
Dec 1, 2023
* better management proxy detection * fix checkstyle issue * add test * test should read the body also * use ObjectMapper * assert read ammount
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address a UX confusion where the console goes into "no management proxy mode" when in-fact the coordinator leader can simply not be determined in a transitive state. This is because right now the console relies on havign
/proxy/coordinator/statusreturn 200 to know that the management proxy is enabled. But that call might fail even when the management proxy is on.In this PR I add a
/proxy/enabledendpoint that simply returns{"enabled":true}and retool the console to use that route instead. Also I allow for a code 400 to indicate that the management proxy is running.