-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deadlock that can occur while merging group by results #15420
Merged
LakshSingla
merged 36 commits into
apache:master
from
LakshSingla:merge-buffer-deadlock
Apr 22, 2024
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
de216d5
init commit
LakshSingla 35bf551
test cases fix
LakshSingla 09689e9
test cases fix 2
LakshSingla e85f4b0
test cases fix 3
LakshSingla ce89fdf
test cases fix 4
LakshSingla a34bcde
caching clustered client removes the flag before sending the requests
LakshSingla a4f476d
fix test
LakshSingla fe32796
add comments
LakshSingla 6ecd555
Merge branch 'master' into merge-buffer-deadlock
LakshSingla b168ce9
init 2
LakshSingla 6cd8aa0
some tests fix
LakshSingla ac44edb
merge and fix build
LakshSingla d2886bc
tests
LakshSingla ceef4f1
Merge branch 'master' into merge-buffer-deadlock
LakshSingla 75aee0a
compilation
LakshSingla 951dce2
compilation benchmarks
LakshSingla 3c1b124
compilation benchmarks, responseContext changes revert
LakshSingla 8c72a92
DumpSegment test fix
LakshSingla bcfabf8
compilation and tests
LakshSingla 3c7fd81
codeql and test
LakshSingla e110662
histogram test
LakshSingla 14f5bab
distinctcount test
LakshSingla d956e73
groupByTimeseriesRunnerTest
LakshSingla bf57bcc
fix issue with unions
LakshSingla 2c3e675
unit test fix
LakshSingla dc2aa53
test fix
LakshSingla 430f2e5
fix it util to properly display error message
LakshSingla 76bc024
new runner
LakshSingla 349e8d9
Merge branch 'master' into merge-buffer-deadlock
LakshSingla d26f7fc
comments, test cases
LakshSingla b3850df
Merge branch 'master' into merge-buffer-deadlock
LakshSingla 8f255d7
checkstyle
LakshSingla 6980d77
query resource id
LakshSingla e2da72a
review comments
LakshSingla 9271043
comments, tests
LakshSingla b8eada8
review final
LakshSingla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add javadoc for what
willMergeRunner
means. I recognize most other stuff in here doesn't have javadocs, but, still.