Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Fix expression result writing of arrays in Hadoop Ingestion #15153

Merged
merged 1 commit into from
Oct 14, 2023
Merged

[Backport] Fix expression result writing of arrays in Hadoop Ingestion #15153

merged 1 commit into from
Oct 14, 2023
+85 −9

Conversation

pranavbhole
Copy link
Contributor

Backport:
#15127

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@clintropolis clintropolis changed the title Fix expression result writing of arrays in Hadoop Ingestion (#15127) [Backport] Fix expression result writing of arrays in Hadoop Ingestion (#15127) Oct 13, 2023
@clintropolis clintropolis added this to the 28.0 milestone Oct 13, 2023
LakshSingla
LakshSingla approved these changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@LakshSingla LakshSingla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSQ tests have been failing, and unrelated the change.

@LakshSingla LakshSingla merged commit e1a6c3a into apache:28.0.0 Oct 14, 2023
80 of 81 checks passed
@LakshSingla LakshSingla changed the title [Backport] Fix expression result writing of arrays in Hadoop Ingestion (#15127) [Backport] Fix expression result writing of arrays in Hadoop Ingestion Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LakshSingla LakshSingla LakshSingla approved these changes

Assignees
No one assigned
Labels
Area - Segment Format and Ser/De Backport
Projects
None yet
Milestone
28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pranavbhole @LakshSingla @clintropolis