Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build reliablity fixes #15048

Merged
merged 12 commits into from
Sep 28, 2023
Merged

Build reliablity fixes #15048

merged 12 commits into from
Sep 28, 2023

Conversation

kgyrtkirk
Copy link
Member

@kgyrtkirk kgyrtkirk commented Sep 27, 2023

  • disable parallel builds in CI - could potentially fix the shader issue by making the build more reliable
  • possibly enable m2 artifact restoration for integration test builds
  • enable batch mode -B (disables download progress)
  • fix one test missing NullHandling.init

@kgyrtkirk kgyrtkirk marked this pull request as ready for review September 27, 2023 12:50
@abhishekagarwal87
Copy link
Contributor

Thanks for taking this up. How much slowdown did you observe after disabling parallel build? I have seen dramatic difference locally when building parallelly vs sequentially.

@kgyrtkirk
Copy link
Member Author

In CI builds - I don't see any significant differences; but they all used the ./it.sh ci which was executing a non-parallel build

I think this patch may only affect the execution time of locally run integraion-tests

For the command: time mvn verify -P integration-tests -pl integration-tests -Dgroups=http-endpoint1

without patch with patch
#1 2m22 2m49
#2 2m17 2m30
#3 2m8 2m30

@kgyrtkirk
Copy link
Member Author

this patch also reduces the gap between seq/paralell build for a command like:
time mvn -q clean install -P dist -DskipTests -Pskip-static-checks

worktree is already built built; artifacts cached

w/o; seq w/o; T8 patch; seq patch;T8
run#1 6m17 2m18 3m50 2m10
run#2 6m22 2m17 3m49 2m11
run#3 6m18 2m16 3m54 2m10

@gianm gianm merged commit 5f3b310 into apache:master Sep 28, 2023
74 checks passed
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants