Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a TaskReport for "kill" tasks #15023

Merged
merged 4 commits into from
Sep 23, 2023
Merged

Conversation

kfaraz
Copy link
Contributor

@kfaraz kfaraz commented Sep 21, 2023

Changes

  • Add KillTaskReport that contains stats for numSegmentsKilled, numBatchesProcessed, numSegmentsMarkedAsUnused
  • Fix bug where exception message had no formatter but was was still being passed some args.
  • Add some comments regarding deprecation of markAsUnused flag.

Release note

Kill tasks that delete unused segments now publish a task report containing kill stats such as numSegmentsKilled, numBatchesProcessed, numSegmentsMarkedAsUnused.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kfaraz
Copy link
Contributor Author

kfaraz commented Sep 22, 2023

Thanks for the review, @zachjsh ! I have updated the PR based on your feedback.

@kfaraz kfaraz requested a review from zachjsh September 22, 2023 06:36
Copy link
Contributor

@zachjsh zachjsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kfaraz kfaraz merged commit d7c152c into apache:master Sep 23, 2023
74 checks passed
@kfaraz kfaraz deleted the add_kill_comments branch September 23, 2023 02:14
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants