Remove EOFException catch block from the Avro decoders
#15018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianm
reviewed
Sep 20, 2023
...-extensions/src/main/java/org/apache/druid/data/input/avro/InlineSchemaAvroBytesDecoder.java
Show resolved
Hide resolved
abhishekrb19
changed the title
EOFException block with IOException block in the Avro extension
zachjsh
approved these changes
Sep 21, 2023
|
Thanks for the reviews! Updated the PR with additional tests that were missing and cleaned up the exception handling code a little bit. |
abhishekrb19
changed the title
EOFException block with IOException block in the Avro extensionEOFException catch block from the Avro decoders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Avro 1.11.1, the
read()method only throwsIOException.This PR removes the old
EOFExceptioncatch block and now only has anExceptionblock to catchIOExceptionor other classes of exceptions, which is then thrown as a genericParseException.Also, did a minor cleanup of surrounding exception messages around interpolations and capitalization. Added unit tests to tests different parsing errors.
This PR has: