Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove istrue, isfalse vectorized impls. #14991

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Remove istrue, isfalse vectorized impls. #14991

merged 2 commits into from
Sep 25, 2023
+9 −30

Commits on Sep 14, 2023

  1. Remove istrue, isfalse vectorized impls. 

    These were added in apache#14977, but the implementations are incorrect, because
they return null when the input arg is null. They should return false when
the input is null. Remove them for now, rather than fixing them, since
they're so new that they might as well never have existed.
    @gianm
    gianm committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    0f7c061 View commit details
    Browse the repository at this point in the history

  2. Fix test.

    @gianm
    gianm committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    29df684 View commit details
    Browse the repository at this point in the history