Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: Plan non-equijoin conditions as cross join followed by filter. #14978

Merged
merged 5 commits into from
Sep 19, 2023

Commits on Sep 13, 2023

  1. SQL: Plan non-equijoin conditions as cross join followed by filter.

    Druid has previously refused to execute joins with non-equality-based
    conditions. This was well-intentioned: the idea was to push people to
    write their queries in a different, hopefully more performant way.
    
    But as we're moving towards fuller SQL support, it makes more sense to
    allow these conditions to go through with the best plan we can come up
    with: a cross join followed by a filter. In some cases this will allow
    the query to run, and people will be happy with that. In other cases,
    it will run into resource limits during execution. But we should at
    least give the query a chance.
    
    This patch also updates the documentation to explain how people can
    tell whether their queries are being planned this way.
    gianm committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    00f9d4a View commit details
    Browse the repository at this point in the history
  2. cartesian is a word.

    gianm committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    f880173 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Configuration menu
    Copy the full SHA
    8c0db41 View commit details
    Browse the repository at this point in the history
  2. Adjust tests.

    gianm committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    8a5292e View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Update docs/querying/datasource.md

    Co-authored-by: Benedict Jin <asdf2014@apache.org>
    gianm and asdf2014 authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    6e35a14 View commit details
    Browse the repository at this point in the history