Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IS [NOT] DISTINCT FROM to SQL and join matchers. #14976

Merged
merged 8 commits into from
Sep 20, 2023

Commits on Sep 13, 2023

  1. Add IS [NOT] DISTINCT FROM to SQL and join matchers.

    Changes:
    
    1) Add "isdistinctfrom" and "notdistinctfrom" native expressions.
    
    2) Add "IS [NOT] DISTINCT FROM" to SQL. It uses the new native expressions
       when generating expressions, and is treated the same as equals and
       not-equals when generating native filters on literals.
    
    3) Update join matchers to have an "includeNull" parameter that determines
       whether we are operating in "equals" mode or "is not distinct from"
       mode.
    gianm committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    3b3bb93 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Main changes:

    - Add ARRAY handling to "notdistinctfrom" and "isdistinctfrom".
    - Include null in pushed-down filters when using "notdistinctfrom" in a join.
    
    Other changes:
    - Adjust join filter analyzer to more explicitly use InDimFilter's ValuesSets,
      relying less on remembering to get it right to avoid copies.
    gianm committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    0d7ab1e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f15b41f View commit details
    Browse the repository at this point in the history
  3. Remove unused "wrap" method.

    gianm committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    5d838c4 View commit details
    Browse the repository at this point in the history
  4. Fixes.

    gianm committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    96d1da4 View commit details
    Browse the repository at this point in the history
  5. Remove methods we do not need.

    gianm committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    c23d4a3 View commit details
    Browse the repository at this point in the history
  6. Fix bug with INPUT_REF.

    gianm committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    1b15bea View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Configuration menu
    Copy the full SHA
    45af37e View commit details
    Browse the repository at this point in the history