-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add note about transparent_reconnection #14953
Conversation
docs/api-reference/sql-jdbc.md
Outdated
@@ -30,7 +30,8 @@ sidebar_label: SQL JDBC driver | |||
|
|||
|
|||
You can make [Druid SQL](../querying/sql.md) queries using the [Avatica JDBC driver](https://calcite.apache.org/avatica/downloads/). | |||
We recommend using Avatica JDBC driver version 1.22.0 or later. | |||
We recommend using Avatica JDBC driver version 1.22.0 or later. Note that starting with Avatica 1.21.0, you may need to set the [`transparent_reconnection`](https://calcite.apache.org/avatica/docs/client_reference.html#transparent_reconnection) property to `true` if you notice intermittent query failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are using 1.23 now should this be 1.23 ? Or since the change came after 1.21 this should be 1.21 ? I think 1.23 but have no pressing case against it as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know where that original recommendation for the version came from, so your suggestion for versions would probably be what we go with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok lets change this to 1.23 rest looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the change to version 1.23
This looks good am merging this |
Avatica 1.21.0 changed some default behavior that could lead to intermittent query failures.
This PR has: