docs: add note about transparent_reconnection #14953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavbhole
approved these changes
Sep 8, 2023
soumyava
reviewed
Sep 8, 2023
docs/api-reference/sql-jdbc.md
Outdated
| @@ -30,7 +30,8 @@ sidebar_label: SQL JDBC driver | |||
|
|
|||
|
|
|||
| You can make [Druid SQL](../querying/sql.md) queries using the [Avatica JDBC driver](https://calcite.apache.org/avatica/downloads/). | |||
| We recommend using Avatica JDBC driver version 1.22.0 or later. | |||
| We recommend using Avatica JDBC driver version 1.22.0 or later. Note that starting with Avatica 1.21.0, you may need to set the [`transparent_reconnection`](https://calcite.apache.org/avatica/docs/client_reference.html#transparent_reconnection) property to `true` if you notice intermittent query failures. | |||
There was a problem hiding this comment.
Since we are using 1.23 now should this be 1.23 ? Or since the change came after 1.21 this should be 1.21 ? I think 1.23 but have no pressing case against it as well
There was a problem hiding this comment.
I don't know where that original recommendation for the version came from, so your suggestion for versions would probably be what we go with.
There was a problem hiding this comment.
Ok lets change this to 1.23 rest looks good
soumyava
approved these changes
Sep 8, 2023
317brian
commented
Sep 11, 2023
|
This looks good am merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avatica 1.21.0 changed some default behavior that could lead to intermittent query failures.
This PR has: