Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error messages relating to OVERWRITE keyword #14870

Merged
merged 9 commits into from
Aug 22, 2023
Merged

Fix error messages relating to OVERWRITE keyword #14870

merged 9 commits into from
Aug 22, 2023

Conversation

kgyrtkirk
Copy link
Member

@kgyrtkirk kgyrtkirk commented Aug 18, 2023 •
edited
Loading

Due to the larger size of the #14510 some minor issues were postponed.

  • OVERWRITE should not be a fully reserved keyword
  • some error messages around REPLACE INTO dst OVERWRITE have become cryptic

This PR has:

  • been self-reviewed.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.

@kgyrtkirk
Copy link
Member Author

not sure if I shouId keep this in one piece; most likely the variance related stuff may start some discussions

@kgyrtkirk kgyrtkirk changed the title Use default typesystem logic for unknown types instead of returning double, fix some error messages Fix error messages relating to OVERWRITE keyword Aug 21, 2023
@kgyrtkirk kgyrtkirk marked this pull request as ready for review August 21, 2023 20:58
@abhishekagarwal87 abhishekagarwal87 merged commit 14c1aff into apache:master Aug 22, 2023
74 checks passed
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
@LakshSingla LakshSingla mentioned this pull request Nov 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishekagarwal87 abhishekagarwal87 abhishekagarwal87 approved these changes

Assignees
No one assigned
Labels
Area - SQL
Projects
None yet
Milestone
28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kgyrtkirk @abhishekagarwal87 @LakshSingla