Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web console: make retention dialog clearer #14793

Merged
merged 5 commits into from
Aug 11, 2023

Conversation

vogievetsky
Copy link
Contributor

Small UX tweaks to the retention dialog around how the cluster default rules are presented

Form mode:

image

JSON mode:

image
  1. Render the default rules in the same way as the datasource rules just disabled
  2. when switching the the JSON view the defaults turn to read only JSON also to show, intuitively, that they are the "same type of thing"
  3. Added some explanatory text after the "Cluster defaults" label.

Co-authored-by: Suneet Saldanha <suneet@apache.org>
Copy link
Contributor

@suneet-s suneet-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 after CI. Thanks @vogievetsky !

@vogievetsky vogievetsky merged commit b0c78ff into apache:master Aug 11, 2023
10 checks passed
@vogievetsky vogievetsky deleted the make_rules_ux_better branch August 11, 2023 16:43
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants