Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web console: expose new coordinator properties in the dialog #14791

Merged
merged 2 commits into from
Aug 17, 2023
+30 −0
Merged

Web console: expose new coordinator properties in the dialog #14791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23c40de
expose new coordinator properties in the dialog
vogievetsky Aug 9, 2023
2f5280b
escape
vogievetsky Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions web-console/src/druid-models/coordinator-dynamic-config/coordinator-dynamic-config.mock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ export const DEFAULT_COORDINATOR_DYNAMIC_CONFIG: CoordinatorDynamicConfig = {
replicationThrottleLimit: 500,
balancerComputeThreads: 1,
killDataSourceWhitelist: [],
killTaskSlotRatio: 1,
maxKillTaskSlots: 2147483647,
killPendingSegmentsSkipList: [],
maxSegmentsInNodeLoadingQueue: 500,
decommissioningNodes: [],
Expand Down
28 changes: 28 additions & 0 deletions web-console/src/druid-models/coordinator-dynamic-config/coordinator-dynamic-config.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ export interface CoordinatorDynamicConfig {
balancerComputeThreads?: number;
killAllDataSources?: boolean;
killDataSourceWhitelist?: string[];
killTaskSlotRatio?: number;
maxKillTaskSlots?: number;
killPendingSegmentsSkipList?: string[];
maxSegmentsInNodeLoadingQueue?: number;
mergeBytesLimit?: number;
Expand Down Expand Up @@ -229,6 +231,32 @@ export const COORDINATOR_DYNAMIC_CONFIG_FIELDS: Field<CoordinatorDynamicConfig>[
</>
),
},
{
name: 'killTaskSlotRatio',
type: 'ratio',
defaultValue: 1,
info: (
<>
Ratio of total available task slots, including autoscaling if applicable that will be
allowed for kill tasks. This limit only applies for kill tasks that are spawned
automatically by the Coordinator&apos;s auto kill duty, which is enabled when
<Code>druid.coordinator.kill.on</Code> is true.
</>
),
},
{
name: 'maxKillTaskSlots',
type: 'number',
defaultValue: 2147483647,
info: (
<>
Maximum number of tasks that will be allowed for kill tasks. This limit only applies for
kill tasks that are spawned automatically by the Coordinator&apos;s auto kill duty, which is
enabled when <Code>druid.coordinator.kill.on</Code> is true.
</>
),
min: 1,
},
{
name: 'balancerComputeThreads',
type: 'number',
Expand Down