Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jackson-databind to 2.12.7 #14770

Merged

Conversation

tejaswini-imply
Copy link
Member

@tejaswini-imply tejaswini-imply commented Aug 7, 2023

The current version of jackson-databind is flagged for vulnerabilities CVE-2020-28491 (Although cbor format is not used in druid), CVE-2020-36518 (Seems genuine as deeply nested json in can cause resource exhaustion). Updating the dependency to the latest version 2.12.7 to fix these vulnerabilities.

Now that Hadoop2 is being removed, this upgrade is deemed to be safely made.

} else if (m instanceof AnnotatedMethod) {
genericType = ((AnnotatedMethod) m).getAnnotated().getGenericReturnType();
} else if (m instanceof AnnotatedParameter) {
genericType = ((AnnotatedParameter) m).getOwner().getGenericParameterType(((AnnotatedParameter) m).getIndex());

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
AnnotatedWithParams.getGenericParameterType
should be avoided because it has been deprecated.
@abhishekagarwal87
Copy link
Contributor

FYI anyone reading this PR, we cannot upgrade to a version beyond 2.12 because of this change FasterXML/jackson-jaxrs-providers#134
If we want to upgrade to 2.15, one option is to copy the source code of javax.ws.rs.core.NoContentException

@abhishekagarwal87 abhishekagarwal87 merged commit 550a66d into apache:master Aug 9, 2023
79 of 81 checks passed
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants