Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrays and approximate count aggregators #14656

Closed
wants to merge 2 commits into from
Closed

arrays and approximate count aggregators #14656

wants to merge 2 commits into from

Conversation

clintropolis
Copy link
Member

Description

Split out support for ARRAY typed inputs to HLL and Theta sketches, as well as bloom filter and aggregator from #14542 to give it a proper standalone review.

changes:

  • add support to hll and theta sketch aggs for array inputs, converting arrays to byte[] form. native agg specs have a flag to indicate if ingest time lists should be handled as arrays or mvds
  • add support to bloom filter and aggregator for array inputs, converting arrays to byte[] form

Screenshot 2023-07-07 at 1 28 50 AM

Release note

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • been tested in a test Druid cluster.

@clintropolis
arrays and aggregators
2a8ff88 
changes:
* add support to hll and theta sketch aggs for array inputs, converting arrays to byte[] form. native agg specs have a flag to indicate if ingest time lists should be handled as arrays or mvds
* add support to bloom filter and aggregator for array inputs, converting arrays to byte[] form
@github-actions GitHub Actions
Copy link

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 15, 2024
@github-actions GitHub Actions
Copy link

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 15, 2024
@github-actions GitHub Actions
Copy link

This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area - Ingestion Area - Querying Design Review stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@clintropolis