Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Kafka supervisor topic #14651

Merged
merged 12 commits into from
Aug 21, 2023
Merged

Clean up Kafka supervisor topic #14651

merged 12 commits into from
Aug 21, 2023

Conversation

ektravel
Copy link
Contributor

@ektravel ektravel commented Jul 24, 2023 •
edited
Loading

Description

This PR:

  • places intermediateHandoffPeriod after maxTotalRows
  • documents skipBytesInMemoryOverheadCheck
  • removes future tense
  • removes most of passive voice

This PR has:

  • been self-reviewed.

techdocsmith
techdocsmith approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved after nits

docs/development/extensions-core/kafka-supervisor-reference.md Outdated Show resolved Hide resolved
docs/development/extensions-core/kafka-supervisor-reference.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
docs/development/extensions-core/kafka-supervisor-reference.md Outdated Show resolved Hide resolved
@vtlim vtlim merged commit 5f74ef5 into apache:master Aug 21, 2023
10 checks passed
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techdocsmith techdocsmith techdocsmith approved these changes

Assignees
No one assigned
Labels
Area - Documentation
Projects
None yet
Milestone
28.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ektravel @techdocsmith @vtlim @LakshSingla