Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: query from deep storage #14609
docs: query from deep storage #14609
Changes from 18 commits
6dadb9d
04e784d
671d31c
8dbad1d
9ae0893
20f808b
7dc14c1
9d0d4a3
05057df
3c1d839
8fb3675
11c749a
9b45bfa
52e0d2f
ac0f39e
ef8039c
cf24f72
a771418
7880654
a1af5ca
f2b1526
ca26e60
61dc630
7afd40f
334cf62
dcf98ef
102f421
d310277
c2c12a7
bc4d974
110e840
5dd46b1
26a9032
c8ae087
832a58d
774adca
ff632a4
9e3109c
9840cb5
a5d1e44
a17a19d
231171b
39e3633
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The response why execution mode is async is this pojo: https://github.com/apache/druid/blob/master/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/entity/SqlStatementResult.java
We might want to mention that in the response payload.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you attempt to get the results of a failed query, druid return's a 404.
If you attempt to get the results of a ingestion/replace query, druid returns an empty response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the DELETE and GET requests only work for queries that were POSTed using
/sql/statements
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cryptoe are there any new durable storage configs specifically for query from deep storage? Or are results written to the
tempDir
property?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tempDir is used more as a staging directory before pushing out bytes to s3. Its not related to results of the query.